it should not be possible to create extractor on ennemies lab planet #75

Closed
opened 2026-08-16 21:20:59 +00:00 by metaheavens · 1 comment
Owner
No description provided.
Author
Owner

Implemented and pushed in 63d0d6a.

Three small research-lab-planet polish items bundled together:

#74 - research lab planets (#63) were rare enough to rarely see; raised WorldGen.RESEARCH_LAB_CHANCE from 0.08 to 0.16.

#75 - a research lab planet has no resource_type to extract, but the extractor build flow let you place one there anyway with nothing to show for it. BuildController now refuses the placement with an explicit " has nothing to extract" status message before spending anything.

#76 - the surface capture label just said "CONQUERED" on a research lab planet with no indication of what capturing it actually granted. It now reads "CONQUERED - +1 RESEARCH POINT" specifically for research lab planets.

Tests: new tests/test_research_lab_extractor_gate.gd (bash tests/run_tests.sh research_lab_extractor_gate) covers #75 directly. #74/#76 verified via screenshot + code review (chance/label-text changes, no new branchable logic worth a dedicated test). Also had to patch two pre-existing tests (test_extractor_building.gd, test_planet_conquest_gate.gd) whose "first chunk found" scans happened to land on a research-lab planet in this world's fixed seed - excluded that planet type from their unrelated scans.

Implemented and pushed in `63d0d6a`. Three small research-lab-planet polish items bundled together: **#74** - research lab planets (#63) were rare enough to rarely see; raised `WorldGen.RESEARCH_LAB_CHANCE` from 0.08 to 0.16. **#75** - a research lab planet has no `resource_type` to extract, but the extractor build flow let you place one there anyway with nothing to show for it. `BuildController` now refuses the placement with an explicit "<planet> has nothing to extract" status message before spending anything. **#76** - the surface capture label just said "CONQUERED" on a research lab planet with no indication of what capturing it actually granted. It now reads "CONQUERED - +1 RESEARCH POINT" specifically for research lab planets. Tests: new `tests/test_research_lab_extractor_gate.gd` (`bash tests/run_tests.sh research_lab_extractor_gate`) covers #75 directly. #74/#76 verified via screenshot + code review (chance/label-text changes, no new branchable logic worth a dedicated test). Also had to patch two pre-existing tests (`test_extractor_building.gd`, `test_planet_conquest_gate.gd`) whose "first chunk found" scans happened to land on a research-lab planet in this world's fixed seed - excluded that planet type from their unrelated scans.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#75
No description provided.