metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

Build the accretion disc once per spawn, not twice

Browse source 
Planet.gd calls visual.configure() BEFORE add_child(), and the SceneTree
defers _ready() to the first frame - so configure() built the five rings,
and _ready() then threw them away and built five more. Eighty antialiased
polylines tessellated per black hole instead of forty, plus five nodes
queued for free.

Confirmed by instrumenting _build():

  _build() called, existing children=0    <- configure()
  _build() called, existing children=5    <- _ready()

_ready() now uses the same is-it-built guard configure() already had.

Note for anyone chasing the same thing: this is NOT the disc's steady-state
cost. Measured, the geometry rasterises zero times over sixty frames (the
NeonPiece refactor works), and rendering the disc costs 0.1 ms against a
133 ms softpipe floor. The disc is cheap once it exists.

172/172.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019AJMdB7iuHuLFZM1aBu3GD
This commit is contained in:
Claude 2026-09-08 22:35:41 +02:00
commit aaf8b400ef
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
planets/BlackHoleVisual.gd
View file

@ -26,7 +26,12 @@ var _rings: Array = []
func _ready() -> void:
_build()
# Planet.gd calls configure() BEFORE add_child(), so the disc is usually
# already built by the time _ready fires (which the SceneTree defers to
# the first frame). Without this guard the ring set was thrown away and
# re-tessellated - eighty antialiased polylines per spawn instead of forty.
if _rings.is_empty():
_build()
func configure(_shape_seed: int) -> void: