Loïc Wisniewski
ee9d6ad9c6
Fix every button being permanently blocked after closing the build menu
...
The real cause of "the crafter buttons do nothing", reported three
times. IconButton._blocked_by_modal tested `menu.visible`, but hiding a
parent leaves a child's own `visible` flag true - and the build menu's
info popup is itself one of the modal panels. So opening any building's
info popup and then closing the build menu with the X left an invisible
popup still claiming to be open, and from that moment EVERY button in
the game was blocked, with no way for a player to get out of it.
It tests is_visible_in_tree() now, and closing the build menu also
closes its popup rather than leaving it half-open.
My earlier attempts kept missing it because the probes called the
handlers directly - they exercised the crafter logic, which was fine all
along, and never the input path in that state. The regression test
reproduces the exact sequence: open the build menu, show a building's
info, hide the menu, then check an unrelated button still fires.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-11 23:41:00 +02:00
android
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
fonts
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
tests
Fix every button being permanently blocked after closing the build menu
2026-08-11 23:41:00 +02:00
.gitignore
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Asteroid.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Asteroid.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Asteroid.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
AsteroidExplosionVFX.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
AsteroidExplosionVFX.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
AsteroidField.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
AsteroidField.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
BuildController.gd
Fix every button being permanently blocked after closing the build menu
2026-08-11 23:41:00 +02:00
BuildController.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Building.gd
Ship Lab: per-vessel research, and the shield vessel
2026-08-11 23:31:49 +02:00
Building.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Building.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
BuildingField.gd
Supply a building by hand: withdraw at the mothership, unload on arrival
2026-08-11 16:36:11 +02:00
BuildingField.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
CargoCounter.gd
Show what the fleet is carrying next to what is banked
2026-08-11 16:04:40 +02:00
CargoCounter.gd.uid
Show what the fleet is carrying next to what is banked
2026-08-11 16:04:40 +02:00
Enemy.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Enemy.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Enemy.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
EnemyExplosionVFX.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
EnemyExplosionVFX.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
EnemySpawner.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
EnemySpawner.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ExplorationTracker.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ExplorationTracker.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ExplosionParticle.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
ExplosionParticle.gd.uid
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
ExplosionVFXBase.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
ExplosionVFXBase.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
export_presets.cfg
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Fleet.gd
Typed owed vessels, ship lab building type, shield vessel gate
2026-08-11 23:10:07 +02:00
Fleet.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
FormationEditor.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
FormationEditor.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
GameController.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
GameController.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
GameState.gd
Typed owed vessels, ship lab building type, shield vessel gate
2026-08-11 23:10:07 +02:00
GameState.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Hauler.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Hauler.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Hauler.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
HaulerField.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
HaulerField.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
icon.svg
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
icon.svg.import
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
IconButton.gd
Fix every button being permanently blocked after closing the build menu
2026-08-11 23:41:00 +02:00
IconButton.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
LightBurstVFX.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
LightBurstVFX.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
lunar_surface.gdshader
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
lunar_surface.gdshader.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
LunarBackground.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
LunarBackground.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Main.tscn
Ship Lab: per-vessel research, and the shield vessel
2026-08-11 23:31:49 +02:00
NeonDraw.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
NeonDraw.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
NeonNumber.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
NeonNumber.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
NeonPanel.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
NeonPanel.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
NeonPiece.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
NeonPiece.gd.uid
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
Planet.gd
Show the extractor derrick the moment it is built, not on respawn
2026-08-11 15:43:43 +02:00
Planet.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Planet.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetAtmosphereController.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetAtmosphereController.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetField.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetField.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetSurface.tscn
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
PlanetSurfaceController.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
PlanetSurfaceController.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
project.godot
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Projectile.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
Projectile.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Projectile.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ResourceCounter.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ResourceCounter.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Rock.gd
Fleet carries mined ore until it delivers it to the mothership
2026-08-11 15:55:45 +02:00
Rock.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Rock.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
RockField.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
RockField.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Ship.gd
Repair a broken working tree, and make every crafter press report
2026-08-11 22:50:09 +02:00
Ship.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Ship.tscn
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ShipExplosionVFX.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ShipExplosionVFX.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
SkillTreeView.gd
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
SkillTreeView.gd.uid
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
Starfield.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Starfield.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
starfield.gdshader
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
starfield.gdshader.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
TouchJoystick.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
TouchJoystick.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
Transporter.gd
Transporter vessels, an explicit store button, and bottom-anchored menus
2026-08-11 19:14:27 +02:00
Transporter.gd.uid
Transporter vessels, an explicit store button, and bottom-anchored menus
2026-08-11 19:14:27 +02:00
Transporter.tscn
Transporter vessels, an explicit store button, and bottom-anchored menus
2026-08-11 19:14:27 +02:00
TransporterField.gd
Transporter vessels, an explicit store button, and bottom-anchored menus
2026-08-11 19:14:27 +02:00
TransporterField.gd.uid
Transporter vessels, an explicit store button, and bottom-anchored menus
2026-08-11 19:14:27 +02:00
ui_theme.tres
Skill tree, node-based building animation, bigger UI, and a 19x faster test suite
2026-08-11 15:00:41 +02:00
ViewUtils.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
ViewUtils.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
WorldGen.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
WorldGen.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
WorldMap.gd
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
WorldMap.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00
WorldMapContent.gd
Ship Lab: per-vessel research, and the shield vessel
2026-08-11 23:31:49 +02:00
WorldMapContent.gd.uid
Initial commit: SpaceshipTest, a top-down space RTS in Godot 4.7.1
2026-08-10 18:41:58 +02:00