fix tech tree menu #93

Closed
opened 2026-08-22 12:33:39 +00:00 by metaheavens · 1 comment
Owner
  • tech tree menu is not taking into account mouse clicks so its not possible
  • now that the button does not exists at the botton, the text can be moved down to give more space to the tree visualisation
- tech tree menu is not taking into account mouse clicks so its not possible - now that the button does not exists at the botton, the text can be moved down to give more space to the tree visualisation
Author
Owner

Both points fixed in 4883197.

Mouse input: the tree only ever handled InputEventScreenTouch / ScreenDrag,
so a real click never reached it. SkillTreeView grew handle_mouse_button
and handle_mouse_motion (thin wrappers over the same press/pan logic the
touch path uses), and BuildController._unhandled_input now routes mouse
events to them while the menu is open. Left click selects, a second click on
the selected node researches it, dragging pans only while held, and the wheel
scrolls the tree either way.

Layout: with the bottom button gone, the readout moved down 154px in
Main.tscn and the tree took the space - it is now 1344px tall instead of
1190px. The detail label, cost and status all shifted with it, so there is no
dead gap left under the tree.

Covered by tests/test_skill_menu.gd, which drives events through the
controller (the routing was the missing piece, so testing the view alone would
not have caught it) across all five behaviours, including asserting no gap
larger than 48px remains below the tree.

Both points fixed in 4883197. Mouse input: the tree only ever handled `InputEventScreenTouch` / `ScreenDrag`, so a real click never reached it. `SkillTreeView` grew `handle_mouse_button` and `handle_mouse_motion` (thin wrappers over the same press/pan logic the touch path uses), and `BuildController._unhandled_input` now routes mouse events to them while the menu is open. Left click selects, a second click on the selected node researches it, dragging pans only while held, and the wheel scrolls the tree either way. Layout: with the bottom button gone, the readout moved down 154px in `Main.tscn` and the tree took the space - it is now 1344px tall instead of 1190px. The detail label, cost and status all shifted with it, so there is no dead gap left under the tree. Covered by `tests/test_skill_menu.gd`, which drives events through the controller (the routing was the missing piece, so testing the view alone would not have caught it) across all five behaviours, including asserting no gap larger than 48px remains below the tree.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#93
No description provided.