pop up to confirm building construction does not adapt to horizontal shape windows, it goes out of bound vertically #92

Closed
opened 2026-08-22 12:31:01 +00:00 by metaheavens · 1 comment
Owner
No description provided.
Author
Owner

Fixed in 01f053e.

The confirm card was a fixed-size centred panel, so on a short window it kept
its portrait height and ran off the top and bottom. NeonPanel now records its
design size on ready, listens for size_changed, and shrinks itself to fit the
viewport minus a 24px margin - clamping only, so it never grows past the size
it was authored at.

Measured: at 720x1280 the card stays 704x1200 as before; at 1920x1080 it
becomes 704x1032 sitting at y=24, where it previously started at y=-60, off
screen.

Covered by tests/test_build_popup_fits_window.gd, which drives the window
through 720x1280, 1920x1080, 2560x900 and 1280x720 and asserts the card and
both buttons stay inside the viewport.

Fixed in 01f053e. The confirm card was a fixed-size centred panel, so on a short window it kept its portrait height and ran off the top and bottom. `NeonPanel` now records its design size on ready, listens for `size_changed`, and shrinks itself to fit the viewport minus a 24px margin - clamping only, so it never grows past the size it was authored at. Measured: at 720x1280 the card stays 704x1200 as before; at 1920x1080 it becomes 704x1032 sitting at y=24, where it previously started at y=-60, off screen. Covered by `tests/test_build_popup_fits_window.gd`, which drives the window through 720x1280, 1920x1080, 2560x900 and 1280x720 and asserts the card and both buttons stay inside the viewport.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#92
No description provided.