metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

some elements are in front of the player #91

New issue
Closed
opened 2026-08-22 12:29:51 +00:00 by metaheavens · 1 comment
metaheavens commented 2026-08-22 12:29:51 +00:00
Owner
Copy link
  • gas producer on gas planets
- gas producer on gas planets
metaheavens commented 2026-08-23 09:19:04 +00:00
Author
Owner
Copy link

Fixed in 03b1c85.

The gas vents on a gas giant drew over the fleet because SurfaceFeatures is
added after Fleet in PlanetSurface.tscn, so at the default z_index of 0 the
later sibling simply wins and you fly under your own gas source.
GasVentField now sets z_index = -1, the same fix and the same reason as
#50's capture rings and the rocks on a rocky surface.

To stop this recurring, tests/test_surface_feature_depth.gd walks every
surface feature on gas_giant, rocky and research_lab (22 of them) and asserts
each one's effective z is below the ship's. Enemies are deliberately excluded -
they are combatants and share the fleet's plane on purpose.

Fixed in 03b1c85. The gas vents on a gas giant drew over the fleet because `SurfaceFeatures` is added after `Fleet` in `PlanetSurface.tscn`, so at the default z_index of 0 the later sibling simply wins and you fly under your own gas source. `GasVentField` now sets `z_index = -1`, the same fix and the same reason as #50's capture rings and the rocks on a rocky surface. To stop this recurring, `tests/test_surface_feature_depth.gd` walks every surface feature on gas_giant, rocky and research_lab (22 of them) and asserts each one's effective z is below the ship's. Enemies are deliberately excluded - they are combatants and share the fleet's plane on purpose.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#91
No description provided.