metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

remove the thrusters upgrade as the speed should be global to the fleet #73

New issue
Closed
opened 2026-08-16 21:18:55 +00:00 by metaheavens · 1 comment
metaheavens commented 2026-08-16 21:18:55 +00:00
Owner
Copy link
No description provided.
metaheavens commented 2026-08-17 17:58:59 +00:00
Author
Owner
Copy link

Implemented and pushed in 8d089d6.

The interceptor's Thrusters upgrade (int_speed, scaling that one vessel type's own top speed) was redundant now that fleet speed is a single global multiplier via the space-time distorder (#59/#62/#70) - it created confusing, hard-to-reason-about double-scaling and had no clear place in the new mental model. Removed the upgrade resource and its ExtResource reference from InterceptorVesselDefinition.tres (and the equivalent, already-unused one on ShieldVesselDefinition.tres), and deleted InterceptorSpeedUpgrade.tres/ShieldSpeedUpgrade.tres outright.

Updated tests/test_ship_lab.gd, which had asserted a 4th visible upgrade card for the interceptor - now correctly asserts 3.

Tests: tests/test_ship_lab.gd (bash tests/run_tests.sh ship_lab).

Implemented and pushed in `8d089d6`. The interceptor's Thrusters upgrade (`int_speed`, scaling that one vessel type's own top speed) was redundant now that fleet speed is a single global multiplier via the space-time distorder (#59/#62/#70) - it created confusing, hard-to-reason-about double-scaling and had no clear place in the new mental model. Removed the upgrade resource and its `ExtResource` reference from `InterceptorVesselDefinition.tres` (and the equivalent, already-unused one on `ShieldVesselDefinition.tres`), and deleted `InterceptorSpeedUpgrade.tres`/`ShieldSpeedUpgrade.tres` outright. Updated `tests/test_ship_lab.gd`, which had asserted a 4th visible upgrade card for the interceptor - now correctly asserts 3. Tests: `tests/test_ship_lab.gd` (`bash tests/run_tests.sh ship_lab`).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#73
No description provided.