power system research in tech tree overlap another upgrade #70

New issue

Closed

opened 2026-08-16 15:55:07 +00:00 by metaheavens · 1 comment

metaheavens commented 2026-08-16 15:55:07 +00:00

Owner

Copy link

No description provided.

metaheavens referenced this issue from a commit 2026-08-17 17:51:33 +00:00

Fix two skill-tree nodes drawn on top of each other (#70)

metaheavens commented 2026-08-17 17:58:57 +00:00

Author

Owner

Copy link

Implemented and pushed in eaeb6bf.

Root cause: SkillTreeView.node_screen_pos() places every node purely from (skill_depth(id), x) - power_systems and squadron shared both values, so they rendered on the identical pixel with no visual way to tell them apart. Moved squadron/armada from x: 0.50 to x: 0.82 in GameState.SKILL_TREE.

Added a structural regression test to tests/test_skill_tree.gd that walks the whole SKILL_TREE table and fails if any two nodes ever share (depth, x) again, so this class of bug can't silently come back as the tree grows.

Tests: tests/test_skill_tree.gd (bash tests/run_tests.sh skill_tree).

Implemented and pushed in `eaeb6bf`. Root cause: `SkillTreeView.node_screen_pos()` places every node purely from `(skill_depth(id), x)` - `power_systems` and `squadron` shared both values, so they rendered on the identical pixel with no visual way to tell them apart. Moved `squadron`/`armada` from `x: 0.50` to `x: 0.82` in `GameState.SKILL_TREE`. Added a structural regression test to `tests/test_skill_tree.gd` that walks the whole `SKILL_TREE` table and fails if any two nodes ever share `(depth, x)` again, so this class of bug can't silently come back as the tree grows. Tests: `tests/test_skill_tree.gd` (`bash tests/run_tests.sh skill_tree`).

metaheavens closed this issue 2026-08-17 17:58:57 +00:00

metaheavens referenced this issue from a commit 2026-09-05 19:10:40 +00:00

Put every research branch back in its own lane

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

No results found.

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

metaheavens/spaceship#70

No description provided.