When conquering a planet, open a dialog showing the number of research points received #212

Closed
opened 2026-09-05 08:33:09 +00:00 by metaheavens · 1 comment
Owner
No description provided.
Author
Owner

Implemented in commit 6e13b63 on main.

Conquering a planet now opens a dialog on the surface - through the narration banner the surface already carries, so it stops the game and waits to be dismissed like every other turn of the story: the garrison falling, then the research points recovered.

The number comes WITH the planet_conquered signal rather than being reconstructed by the listener. The award depends on the planet definition and the setup's optional override, and a listener recomputing that can disagree with what was actually banked; the signal is emitted after the payment, carrying the amount paid. It reports zero explicitly too, because "this one paid nothing" is what a player deciding where to go next needs to know.

Verification
test_planet_conquest_gate.gd asserts an unrewarded conquest reports 0, and that a 4-point conquest reports 4 and banks exactly that.

Implemented in commit `6e13b63` on `main`. Conquering a planet now opens a dialog on the surface - through the narration banner the surface already carries, so it stops the game and waits to be dismissed like every other turn of the story: the garrison falling, then the research points recovered. The number comes WITH the `planet_conquered` signal rather than being reconstructed by the listener. The award depends on the planet definition and the setup's optional override, and a listener recomputing that can disagree with what was actually banked; the signal is emitted after the payment, carrying the amount paid. It reports zero explicitly too, because "this one paid nothing" is what a player deciding where to go next needs to know. **Verification** `test_planet_conquest_gate.gd` asserts an unrewarded conquest reports 0, and that a 4-point conquest reports 4 and banks exactly that.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#212
No description provided.