Fleet can pick up resources from the mothership and supply a building by hand #17
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part 4 of #12. Depends on the building-stock ticket.
From #12: "there should be a way for our fleet to pick resources from the mothership. if the fleet has resources on it and opens a building that needs thoses resources, they are picked by the building. this will prevent issue with resources transportation if no transporter is yet available".
This is what keeps the game unblockable, so it should land BEFORE transporters exist rather than after - otherwise there is a window where a queued order can never be fulfilled.
Scope
Acceptance
Done in
ff162fa.A "Load ore" button at the mothership moves a batch from the bank into the fleet's hold, and opening a building hands it whatever the fleet is carrying. That completes the loop #16 opened: a queued order can now always be fulfilled by flying the ore over yourself, with no Transport Hub in existence.
Delivery at the mothership is now EDGE triggered on arrival, rather than running every frame the fleet is parked there. This fell out of building the withdraw: with continuous delivery, ore loaded into the hold at the mothership was banked again on the very next frame, so the button would have looked completely broken. Arrival is the event that means something, not presence.
A batch rather than the whole bank, because the hold is the part that can be lost, and emptying the bank in one tap would also strand research - which still spends from the bank.
Test
tests/test_manual_supply_route.gdruns the whole route end to end and checks ore is conserved across it (bank + hold + every building stock). Three mutations caught: reverting delivery to continuous, letting the withdraw overdraw the bank, and unloading into a building without emptying the hold (which duplicates ore).An intermittent failure worth recording
This test passed alone and failed once in a full suite run. The cause was not parallelism:
AsteroidField.set_process(false)only stops NEW chunks spawning, and rocks already in the world keep drifting - one destroyed a parked ship, changing the fleet size the test asserts on. Both new logistics tests now clear existing asteroids and enemies. Three consecutive full runs clean afterwards.Worth flagging because it is a trap for any future test that parks the fleet somewhere and waits: disabling the spawner is not the same as clearing the field.
Full suite: 44/44, three runs in a row.