metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

A building with no life should explode #159

New issue
Closed
opened 2026-08-29 12:19:10 +00:00 by metaheavens · 1 comment
metaheavens commented 2026-08-29 12:19:10 +00:00
Owner
Copy link
No description provided.
metaheavens commented 2026-08-29 13:52:07 +00:00
Author
Owner
Copy link

Done in 4c920f1. You had found the one building that could not.

Every other structure already exploded when its life ran out - damage_building destroys at zero, which emits building_destroyed, which spawns the explosion and the sound. The mothership was exempt: it floored at 1hp, so a battered one sat there reading as dead and never came down.

That exemption was deliberate, to prevent a soft-lock - the bank, the hangar and research all live there. But the soft-lock does not actually exist:

  • the bank is GameState.bank_inventory and the hangar is stored_vessels; both outlive any building, so losing the structure does not lose what is in it
  • the mothership is the one structure research never gates
  • it costs exactly what a single interceptor's hold carries
  • ore comes from asteroids, which do not run out

So the way back is always: mine, fly, rebuild. The exemption is gone, and test_building_health now asserts that recovery path - bank survives, hangar survives, rebuild is ungated and fits one hold - in place of the exemption that used to stand in for it.

While I was there: #130 had quietly made a lost vessel bigger than a structure coming down, which inverts what #99 intended. Left as is for now since it is a separate judgement - say the word if you want the structure explosion raised back above it.

Done in `4c920f1`. You had found the one building that could not. Every other structure already exploded when its life ran out - `damage_building` destroys at zero, which emits `building_destroyed`, which spawns the explosion and the sound. The **mothership** was exempt: it floored at 1hp, so a battered one sat there reading as dead and never came down. That exemption was deliberate, to prevent a soft-lock - the bank, the hangar and research all live there. But the soft-lock does not actually exist: - the bank is `GameState.bank_inventory` and the hangar is `stored_vessels`; both outlive any building, so losing the structure does not lose what is in it - the mothership is the one structure research never gates - it costs exactly what a single interceptor's hold carries - ore comes from asteroids, which do not run out So the way back is always: mine, fly, rebuild. The exemption is gone, and `test_building_health` now asserts that recovery path - bank survives, hangar survives, rebuild is ungated and fits one hold - in place of the exemption that used to stand in for it. While I was there: #130 had quietly made a lost *vessel* bigger than a structure coming down, which inverts what #99 intended. Left as is for now since it is a separate judgement - say the word if you want the structure explosion raised back above it.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#159
No description provided.