When in the skill tree, the dialog windows appears behind. dialog should always be on front of everything #154

Closed
opened 2026-08-29 12:06:30 +00:00 by metaheavens · 1 comment
Owner
No description provided.
Author
Owner

Done in b721760.

Confirmed: the banner was the ninth child of the UI layer and every panel came after it. Drawing order inside a CanvasLayer is child order, so all twelve modal panels drew over the top of it - the skill tree being the one you hit.

It is the last child now, in both the space scene and the planet surface. Input order was never the problem and does not change: the UI layer already receives unhandled input before the controllers do, so a click on a dialog over the skill tree was already being eaten by the dialog rather than reaching the tree.

The test asserts it by index rather than by eye - the banner must be the last child of the UI layer, and no node in modal_menus may come after it.

Done in `b721760`. Confirmed: the banner was the ninth child of the UI layer and every panel came after it. Drawing order inside a `CanvasLayer` is child order, so all twelve modal panels drew over the top of it - the skill tree being the one you hit. It is the last child now, in both the space scene and the planet surface. Input order was never the problem and does not change: the UI layer already receives unhandled input before the controllers do, so a click on a dialog over the skill tree was already being eaten by the dialog rather than reaching the tree. The test asserts it by index rather than by eye - the banner must be the last child of the UI layer, and no node in `modal_menus` may come after it.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
metaheavens/spaceship#154
No description provided.