metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

Stop redrawing what only needs moving

Browse source 
Reviewed against the rule issues #6 and #10 set for the buildings: geometry
is rasterised once and thereafter only moved, scaled or faded, because every
NeonDraw call expands into four antialiased polylines.

The planet visuals never got that refactor. The black hole rebuilt ten
glowing paths of twenty-five points every frame - forty polylines - to spin
five rings; each ring is a NeonPiece that rotates now. The research lab spent
nine draw calls a frame, eight of them fixed geometry, to turn one dish and
blink six lights; the dish is a child that rotates and the lights a child
whose modulate breathes. The gas giant's bands genuinely deform, so they
still draw, but its constant rim moved out to a child. NeonPiece gained
add_path, which it needed for open arcs.

And I had broken the rule myself. ScannerGuidance re-queued a redraw of its
arrow every frame for a colour that changes only with the destination - and
it runs with PROCESS_MODE_ALWAYS, so it was re-tessellating through every
dialog that stops the rest of the game. Guarded, and pinned by a test that
counts CanvasItem's own draw signal: 36 rasterisations in 0.6s before, one
after.

Two smaller things from the same pass: the station menu drew its condition
bar by hand where the ship lab already uses a ProgressBar node, so it uses
one now and its _draw is gone; and station/upkeep refreshes were wired into
_refresh_garrison(), which nothing but a test calls, so both menus showed
whatever was true when they opened.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019AJMdB7iuHuLFZM1aBu3GD
This commit is contained in:
Loïc Wisniewski 2026-09-08 11:35:45 +02:00
commit 7d1a584c15
11 changed files with 350 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ui/ScannerGuidance.gd
View file

@ -14,6 +14,13 @@ const EDGE_MARGIN: float = 34.0
@onready var target_label: Label = $TargetLabel
var fleet: Node2D
# The colour the arrow was last rasterised with. Issues #6/#10: a glyph is
# drawn once and thereafter moved and rotated, both of which reuse the cached
# geometry. Re-queueing a redraw every frame for a colour that changes only
# when the DESTINATION changes threw that away - and this node runs even
# while the game is stopped for a dialog, so it was the one piece of UI
# re-tessellating itself through the quietest moments in the game.
var _drawn_glow: Color = Color(0, 0, 0, 0)
func _ready() -> void:
@ -53,8 +60,9 @@ func _process(_delta: float) -> void:
# authored colour rather than being forced into one.
var definition: Resource = PLANET_DEFINITIONS.get_definition(
String(target.get("definition_id", "")))
if definition != null:
indicator.glow_color = definition.map_color
if definition != null and definition.map_color != _drawn_glow:
_drawn_glow = definition.map_color
indicator.glow_color = _drawn_glow
indicator.queue_redraw()
var sectors: float = toward_target.length() / WorldGen.CHUNK_SIZE
target_label.text = "%s · %.1f SECTORS" % [