metaheavens/spaceship
Watch
1
0
Fork
You've already forked spaceship
 0
Code Issues 4 Pull requests Projects 1 Releases Packages Wiki Activity

#232: stop rebuilding the gas vents every frame

Browse source 
GasVentField called queue_redraw() every frame and its _draw rebuilt six
vents of seven glowing polygons each - 168 antialiased polylines
re-tessellated per frame, since every NeonDraw call expands into four.

Measured first: 40 rasterisations over 30 frames, costing 6.6ms against a
32.4ms floor. For scale, the black hole's cached disc costs 0.1ms.

Both halves are pieces now. The sources never move, never recolour and never
fade, so they are rasterised once. The rising bubbles genuinely change size
and opacity, but size is scale and opacity is modulate - neither needs the
geometry rebuilding. 40 rasterisations over 30 frames became 0.

Two things worth recording.

The static extraction alone measured NOTHING - 7.1ms against 6.6ms, inside
the noise. softpipe is a CPU rasteriser: it prices FILL, and cached geometry
fills the same pixels. It cannot see a tessellation saving at all. After the
full change the frame time read NEGATIVE with the floor drifting 28 to 39ms
between runs, so no millisecond figure is claimed here. The rasterisation
count is the reproducible result; what it is worth on a phone is unmeasured.

And scaling a NeonPiece scales its STROKE with it. The bubbles were first
built as unit circles scaled up by their radius, which multiplied NeonDraw's
widths by five to fourteen - a hundred pixels of glow around a fourteen
pixel bubble. They rendered as bright blobs, the rasterisation count said
40 -> 0, and only the screenshot disagreed. Built at the largest radius and
scaled DOWN now, so the stroke only ever thins. The trap is noted at the
call site: scale is safe for moving and shrinking a piece and quietly wrong
for growing one.

NeonPiece.add_polygon gained a width, which it needed to keep the vents'
authored stroke rather than silently fattening them.

179/179.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019AJMdB7iuHuLFZM1aBu3GD
This commit is contained in:
Claude 2026-09-14 13:29:22 -04:00 • committed by Loïc Wisniewski
commit 4ebd832a70
2 changed files with 86 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

8
vfx/NeonPiece.gd
View file

@ -34,8 +34,9 @@ static func create(parent: Node, at: Vector2, colour: Color, alpha: float = 1.0)
return piece
func add_polygon(points: PackedVector2Array, piece_pulse: float = 1.0) -> void:
polygons.append({"points": points, "pulse": piece_pulse})
func add_polygon(points: PackedVector2Array, piece_pulse: float = 1.0,
width: float = 1.0) -> void:
polygons.append({"points": points, "pulse": piece_pulse, "width": width})
func add_path(points: PackedVector2Array, piece_pulse: float = 1.0,
@ -49,7 +50,8 @@ func add_line(from: Vector2, to: Vector2, width: float, piece_pulse: float = 1.0
func _draw() -> void:
for poly in polygons:
NeonDraw.draw_glowing_polygon(self, poly.points, glow_color, poly.pulse * pulse, core_color)
NeonDraw.draw_glowing_polygon(self, poly.points, glow_color,
poly.pulse * pulse, core_color, float(poly.get("width", 1.0)))
for path in paths:
NeonDraw.draw_glowing_path(self, path.points, glow_color,
path.pulse * pulse, path.width, core_color)